Closed
Bug 706739
Opened 13 years ago
Closed 13 years ago
Don't evaluate static blocklists and special cases during evaluation of downloaded blocklist
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: drs, Assigned: drs)
References
Details
Attachments
(1 file, 1 obsolete file)
bug 693813 fixed this issue previously, but I reintroduced this bug in 668004. Basically, we have to avoid evaluating any special cases or static blocklist entries when evaluating the downloaded blocklist. We don't want to pref things off if they're already compiled in as being blocked.
|
Assignee | |
Comment 1•13 years ago
|
||
See bug description.
Assignee: nobody → dsherk
Attachment #578497 -
Flags: review?(joe)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=abe278c327db
|
||
Comment 3•13 years ago
|
||
Comment on attachment 578497 [details] [diff] [review] Patch v1.0, don't evaluate static blocklists and special cases during evaluation of dowloaded blocklist. Review of attachment 578497 [details] [diff] [review]: ----------------------------------------------------------------- It'll need rebasing after making changes to dependent patches, but looks good.
Attachment #578497 -
Flags: review?(joe) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Removed comments/old code, +r carried.
Attachment #578497 -
Attachment is obsolete: true
Attachment #579852 -
Flags: review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://tbpl.mozilla.org/?rev=fe937bac6e75
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/49b8bec6d175
Target Milestone: --- → mozilla11
|
||
Comment 7•12 years ago
|
||
Backed out from beta only: http://hg.mozilla.org/releases/mozilla-beta/rev/2fccf5e774a7 See bug 711656 for explanation.
You need to log in
before you can comment on or make changes to this bug.
Description
•