707092 - Crash [@ GetTopLevelWindowActiveState] printing "-moz-appearance: -moz-window-frame-left"

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Load the testcase
2. Print (to file)

Result: Crash [@ GetTopLevelWindowActiveState]

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Jesse Ruderman]

There are a few crash reports per day with a matching signature. Most of the stacks are different or truncated, but they're crashing on the same source code line.

Comment 3

[Jim Mathies [:jimm]]

Attachment: add null check on window ptr

I'll have to remember to use the test case of printing when working on this code. Thanks for reporting.

Comment 4

[Brian R. Bondy [:bbondy]]

Comment on attachment 578592 [details] [diff] [review]
add null check on window ptr

Review of attachment 578592 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/nsNativeThemeWin.cpp
@@ +89,5 @@
>    // until it finds a real window.
>    nsIWidget* widget = aFrame->GetNearestWidget();
>    nsWindow * window = static_cast<nsWindow*>(widget);
> +  if (!window)
> +    return false;

nit: return 0;

Comment 5

[Jim Mathies [:jimm]]

Attachment: return proper constant

much better.

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d311cfc2e4

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/e6d311cfc2e4