Closed Bug 707131 Opened 13 years ago Closed 12 years ago

GCLI Completer could be simplified if repeated spans are not a performance issue

Categories

(DevTools :: Console, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 13

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

Attachments

(1 file)

See Completer.update() and particularly Completer.appendMarkupStatus()

<span>h</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>m</span>
<span>u</span>
<span>c</span>
<span>h</span>
<span> </span>
<span>o</span>
<span>f</span>
<span> </span>
<span>a</span>
<span> </span>
<span>s</span>
<span>l</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>d</span>
<span>o</span>
<span>w</span>
<span>n</span>
<span> </span>
<span>i</span>
<span>s</span>
<span> </span>
<span>t</span>
<span>h</span>
<span>i</span>
<span>s</span>

We're making the code more complex to avoid the situation above, but if there's no perceptable benefit, then simpler code could win out, especially if that meant we could use a template.
Triage. Filter on PEGASUS.
Priority: -- → P4
Triage. Filter on PEGASUS.
No longer blocks: GCLI-FUTURE
win: glob the statuses together in inputStatusMarkup.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attached patch upload 1Splinter Review
a.k.a https://github.com/campd/gcli/pull/20
Attachment #593093 - Flags: review?(dcamp)
Target Milestone: --- → Firefox 13
Comment on attachment 593093 [details] [diff] [review]
upload 1

Does what it says on the label.  These completer dialogs are usually limited to a few lines anyway, right?
Attachment #593093 - Flags: review?(dcamp) → review+
(In reply to Dave Camp (:dcamp) from comment #6)
> Comment on attachment 593093 [details] [diff] [review]
> upload 1
> 
> Does what it says on the label.  These completer dialogs are usually limited
> to a few lines anyway, right?

Yes, and also the replacement code is template based without creating multiple spans - so no performance hit anyway.
Blocks: 724819
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3e9fbc7eb447
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: