Closed
Bug 707131
Opened 13 years ago
Closed 12 years ago
GCLI Completer could be simplified if repeated spans are not a performance issue
Categories
(DevTools :: Console, defect, P4)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
Attachments
(1 file)
18.70 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
See Completer.update() and particularly Completer.appendMarkupStatus() <span>h</span> <span>o</span> <span>w</span> <span> </span> <span>m</span> <span>u</span> <span>c</span> <span>h</span> <span> </span> <span>o</span> <span>f</span> <span> </span> <span>a</span> <span> </span> <span>s</span> <span>l</span> <span>o</span> <span>w</span> <span> </span> <span>d</span> <span>o</span> <span>w</span> <span>n</span> <span> </span> <span>i</span> <span>s</span> <span> </span> <span>t</span> <span>h</span> <span>i</span> <span>s</span> We're making the code more complex to avoid the situation above, but if there's no perceptable benefit, then simpler code could win out, especially if that meant we could use a template.
Assignee | ||
Comment 2•12 years ago
|
||
Triage. Filter on PEGASUS.
Assignee | ||
Updated•12 years ago
|
No longer blocks: GCLI-FUTURE
Assignee | ||
Comment 3•12 years ago
|
||
win: glob the statuses together in inputStatusMarkup.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•12 years ago
|
||
a.k.a https://github.com/campd/gcli/pull/20
Attachment #593093 -
Flags: review?(dcamp)
Assignee | ||
Comment 5•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b447debd6053
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 13
Comment 6•12 years ago
|
||
Comment on attachment 593093 [details] [diff] [review] upload 1 Does what it says on the label. These completer dialogs are usually limited to a few lines anyway, right?
Attachment #593093 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Dave Camp (:dcamp) from comment #6) > Comment on attachment 593093 [details] [diff] [review] > upload 1 > > Does what it says on the label. These completer dialogs are usually limited > to a few lines anyway, right? Yes, and also the replacement code is template based without creating multiple spans - so no performance hit anyway.
Assignee | ||
Comment 8•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=946d867e53b4
Assignee | ||
Comment 9•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=3e9fbc7eb447
Assignee | ||
Updated•12 years ago
|
Whiteboard: [fixed-in-fx-team]
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3e9fbc7eb447
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•