707223 - AzureBackend is not aligned with the other Graphics information in about:support

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[JK]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20100101 Firefox/9.0
Build ID: 20111122192043

Steps to reproduce:

AzureBackend is not aligned with the other Graphics information in about:support.

Comment 1

[JK]

Attachment: screenshot

Comment 2

[Antti Tervasmäki]

It's the same in current Nightly I see...

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:11.0a1) Gecko/20111202 Firefox/11.0a1 ID:20111202031055

Comment 3

[Helder "Lthere" Magalhães]

The cause is that the data is currently being displayed in two different tables which are set to fit to content (the default): in the first table, "graphics-tbody", the header column fits to its longest string, "GPU Accelerated Windows"; in the second table, "graphics-info-properties" is fitting to "AzureBackend".

I'd suggest using a unique table for all graphics information, using two separate "tbody" elements(instead of two different "table" elements) for separating content, keeping the same identifiers for compatibility. Another possible workaround could be setting a percent width, but honestly I don't like that approach (will behave worse in viewport resize and may trigger unexpected issues due to internationalization etc.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Move tbodys into single table

This patch seems to work on my local build.

Asking for review from Jeff since he reviewed the patch in bug 702770 that added the table in the first place. Please redirect the request if I'm doing this wrong. :)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: screenshot with fix

This also gets rid of the not-good-looking double border around the AzureBackend row.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 591667 [details] [diff] [review]
Move tbodys into single table

Looks fine to me.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Version someone can check in for me.

Here's a version that has all of the commit info that someone can use to check this in for me, since I don't have commit access. Carrying forward r+.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b55af240c15

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/7b55af240c15

Comment 10

[banakon]

still NOT aligned here (FF11, Vista sp2).
why?
thanks.

Comment 11

[banakon]

why you say Fixed? very odd...

Comment 12

[Ed Morley [:emorley]]

Target milestone = Mozilla12

Comment 13

[banakon]

sorry sorry 
and thank you for your reply ;)

Comment 14

[Ed Morley [:emorley]]

No problem :-)