Closed
Bug 707498
Opened 13 years ago
Closed 13 years ago
Use a template to get the array length for nsGenericElement::FindAttributeDependence
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
41.25 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
As described at <https://whereswalden.com/2011/10/20/implementing-mozillaarraylength-and-mozillaarrayend-and-some-followup-work/>.
Attachment #578896 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 578896 [details] [diff] [review] Patch v1 Review of attachment 578896 [details] [diff] [review]: ----------------------------------------------------------------- Looks nice. Is this every caller of FindAttributeDependence? If it is, please mark the original FindAttributeDependence function private within nsGenericElement. If it isn't, we should consider whether the other callers could be changed somehow. I'll ping you on IRC tomorrow and we can figure out something here, if something need be figured out.
Attachment #578896 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c74e2c35fd96
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•