707521 - Decoupling JavaScript Breaks Amazon Universal Wishlist

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Michael Coates [:mcoates] (acct no longer active)]

Our recent changes to decouple javascript: urls from the page content fixes security concerns but also breaks some usage such as the amazon universal wish list bookmarklet.  Should we reach out to amazon with this information and provide recommendations on how they can redesign their feature to work with newer firefox versions?  Otherwise, we may receive negative push back as people upgrade and realize this amazon feature (which some people may heavily use) no longer works.

http://www.amazon.com/wishlist/get-button


Here is the javascript bookmarklet that amazon uses:

javascript:(function(){var%20w=window,l=w.location,d=w.document,s=d.createElement('script'),e=encodeURIComponent,o='object',n='AUWLBook',u='https://www.amazon.com/wishlist/add',r='readyState',T=setTimeout,a='setAttribute',g=function(){d[r]&&d[r]!='complete'?T(g,200):!w[n]?(s[a]('charset','UTF-8'),s[a]('src',u+'.js?loc='+e(l)),d.body.appendChild(s),f()):f()},f=function(){!w[n]?T(f,200):w[n].showPopover()};typeof%20s!=o?l.href=u+'?u='+e(l)+'&t='+e(d.title):g()}())

Comment 1

[Michael Coates [:mcoates] (acct no longer active)]

Hmm, it actually does work for me now (tried in nightly and beta 9). Not sure why it wasn't working a moment ago.  But, I was pretty sure our JS changes would break this. Have they landed yet?

(Feel free to mark bug as invalid if I'm totally of base here)

Comment 2

[Brandon Sterne (:bsterne)]

The change (bug 656433) doesn't affect clicking bookmarklets, only typing javascript: URLs in the location bar.  Your problem is unrelated, so I'm going to mark this INVALID.