Closed
Bug 707578
Opened 13 years ago
Closed 12 years ago
Package.pm shouldn't copy older files
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
1.40 KB,
patch
|
robert.strong.bugs
:
review+
khuey
:
review+
|
Details | Diff | Splinter Review |
Packager.pm is currently copying all files regardless of the last modification time. It's currently not changing anything because destination files are removed before copying. However, with bug 707569, we might end up not removing those files (maybe only if a certain env variable is set).
Attachment #578947 -
Flags: review?
|
Assignee | |
Updated•13 years ago
|
Attachment #578947 -
Flags: review? → review?(robert.bugzilla)
|
|
Assignee | |
Comment 1•13 years ago
|
||
By any chance Kyle, do you think you could take this review?
Component: NSIS Installer → Build Config
Product: Toolkit → Core
QA Contact: nsis.installer → build-config
|
||
Comment 2•13 years ago
|
||
Comment on attachment 578947 [details] [diff] [review] Patch v1 Though this code is under installer it is actually packaging code and should be reviewed by Kyle or Ted. I'm ok with the patch but it would be best to have Kyle review it.
Attachment #578947 -
Flags: review?(robert.bugzilla)
Attachment #578947 -
Flags: review?(khuey)
Attachment #578947 -
Flags: review+
Attachment #578947 -
Flags: review?(khuey) → review+
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2b35bacd2193
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•