707654 - embeds relation on root accessible can return not content document

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

For example, if you install Firebug extension then it adds extra document accessible that is returned by embeds relation but the tab document is expected.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ca7d87ab38b6

Comment 3

[Ed Morley [:emorley]]

MarcoZ asked if this could be backed for now due to bug 720393, hope this was ok :-)

https://hg.mozilla.org/mozilla-central/rev/9b069a37f58f

Comment 4

[alexander :surkov (:asurkov)]

I'm surprised that this bug caused bug 720393 because Jamie said embed relations are used for plugin stuffs only so it shouldn't lead to issues observed in bug 720393. Moreover I don't see any changes in behavior (at least prior to bug 591363 which broke it).

I pushed try server build https://tbpl.mozilla.org/?tree=Try&rev=9c9d74894bca. Marco, when it's ready please try it.

Comment 5

[alexander :surkov (:asurkov)]

try server build link http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-9c9d74894bca

Comment 6

[Marco Zehe (:MarcoZ)]

Well, the observation is completely confirmed: I had the issues with this bug in, with it backed out, the situation returned to normal. There were two nightlies built on that day, the first with, the second without the patch after I identified it as being the guilty part. So the backout definitely fixed it.

Comment 7

[James Teh [:Jamie]]

I'm also seeing situations where the first tab document is returned, even if another tab is active. Is this related or should I file another bug?

Comment 8

[alexander :surkov (:asurkov)]

(In reply to James Teh [:Jamie] from comment #7)
> I'm also seeing situations where the first tab document is returned, even if
> another tab is active. Is this related or should I file another bug?

for the record: as I said on irc it's regression from bug 591363.

Comment 9

[James Teh [:Jamie]]

(In reply to alexander :surkov from comment #8)
> > I'm also seeing situations where the first tab document is returned, even if
> > another tab is active.
> for the record: as I said on irc it's regression from bug 591363.
I can confirm this is fixed by this patch.

Marco, I can't reproduce bug 720393 with this try build. I tried with the NVDA Snapshots page (which contains an iframe):
http://www.nvda-project.org/snapshots/
I moved to one of the download links within the iframe. I also tried Gmail and couldn't reproduce it their either. Scarily enough, I can't think of any pages with Facebook or Twitter gadgets on them right now (even though I see them all the time), so haven't tested that yet.

Comment 10

[Marco Zehe (:MarcoZ)]

Strange, I did see it with every try in that short-lived nightly build, and that was, indeed, the only patch that landed. And it had to be a focused item inside. A difference may be that here, there's a lot of test and stuff that comes before the first focusable item, whereas with Twitter widgets the focusable item comes first thing inside those iframes.

Comment 11

[alexander :surkov (:asurkov)]

Marco, do you see any problems with try server build?

Comment 12

[Marco Zehe (:MarcoZ)]

(In reply to alexander :surkov from comment #11)
> Marco, do you see any problems with try server build?

No, this latest try-server build is fine.

Comment 13

[alexander :surkov (:asurkov)]

Ok, I'll land it then again

Comment 14

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c75743aa5bce

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c75743aa5bce