Closed Bug 707733 Opened 13 years ago Closed 12 years ago

Intermittent REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/smil/container/deferred-anim-1.xhtml | image comparison (==)

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16
Tracking Flags:
Tracking Status
firefox15 --- fixed

People

(Reporter: mbrubeck, Assigned: birtles)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

reftest log
16.12 KB, text/plain
Details
Proposed fix v1a
3.72 KB, patch
dholbert
: review+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review 
In image 1, the blue square is slightly left of center.  In image 2 it is slightly right of center.

https://tbpl.mozilla.org/php/getParsedLog.php?id=7751085&tree=Mozilla-Inbound
REFTEST INFO | Loading a blank page
REFTEST TEST-START | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/moved-tree-1.xhtml | 955 / 2398 (39%)
REFTEST TEST-START | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/moved-tree-1-ref.xhtml | 955 / 2398 (39%)
REFTEST TEST-KNOWN-FAIL(EXPECTED RANDOM) | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/moved-tree-1.xhtml | image comparison (==) 
REFTEST INFO | Loading a blank page
REFTEST TEST-START | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-anim-1.xhtml | 956 / 2398 (39%)
REFTEST TEST-START | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-anim-1-ref.xhtml | 956 / 2398 (39%)
REFTEST TEST-UNEXPECTED-FAIL | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-anim-1.xhtml | image comparison (==) 
REFTEST   IMAGE 1 (TEST): [...]before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
before 385024, after 385024, break 057ff000
[...]
REFTEST   IMAGE 2 (REFERENCE): [...]
REFTEST number of differing pixels: 3188
REFTEST INFO | Saved log: START http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-anim-1.xhtml
REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering WaitForTestEnd
REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
REFTEST INFO | Saved log: Initializing canvas snapshot
REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for MozAfterPaint
REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-anim-1.xhtml
REFTEST INFO | Saved log: Updating canvas for invalidation
REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
REFTEST INFO | Saved log: [CONTENT] AttrModifiedListener fired
REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-anim-1.xhtml
REFTEST INFO | Saved log: Updating canvas for invalidation
REFTEST INFO | Saved log: DoDrawWindow 34,87,69,42
REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
REFTEST INFO | Saved log: [CONTENT] MakeProgress: dispatching MozReftestInvalidate
REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FINISH
REFTEST INFO | Saved log: [CONTENT] MakeProgress: Completed
REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_COMPLETED
REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_COMPLETED
REFTEST INFO | Saved log: [CONTENT] RecordResult fired
REFTEST INFO | Saved log: RecordResult fired
REFTEST INFO | Saved log: START http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-anim-1-ref.xhtml
REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
REFTEST INFO | Saved log: Initializing canvas snapshot
REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
REFTEST INFO | Saved log: [CONTENT] RecordResult fired
REFTEST INFO | Saved log: RecordResult fired
REFTEST INFO | Loading a blank page
REFTEST TEST-START | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-tree-1.xhtml | 957 / 2398 (39%)
REFTEST TEST-START | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-tree-1-ref.xhtml | 957 / 2398 (39%)
REFTEST TEST-PASS | http://10.250.48.211:30088/tests/layout/reftests/svg/smil/container/deferred-tree-1.xhtml | image comparison (==) 
REFTEST INFO | Loading a blank page
Attached file reftest log — 
Whiteboard: [android_tier_1][orange] → [orange]

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Removing "Android" from the summary, as this happened on WinXP as well (see comment 3) - I'm assuming it's really the same issue.
OS: Android → All
Hardware: ARM → All
Summary: Intermittent Android REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/smil/container/deferred-anim-1.xhtml | image comparison (==) → Intermittent REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/smil/container/deferred-anim-1.xhtml | image comparison (==)
Version: 11 Branch → Trunk

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  
Assignee: nobody → birtles
Status: NEW → ASSIGNED

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Proposed fix v1a
        — 
          — Splinter Review
      

    


  

        Attachment #640834 -
        Flags: review?(dholbert)

    
    

    
      
  

    
    

    
  
Comment on attachment 640834 [details] [diff] [review]
Proposed fix v1a

Looks good! Just one nit:

>+          timeoutID = window.setTimeout(giveUp, 30000);
[...]
>+
>+        function giveUp() {
>+          var svg = document.getElementsByTagName('svg')[0];
>+          var rect = svg.getElementsByTagName('rect')[0];
>+          rect.setAttribute("fill", "red");
>+          finish();
>+        }
>+
>+        function finish() {
>+          if (timeoutID) {
>+            window.clearTimeout(timeoutID);
>+            timeoutID = null;
>+          }

So -- giveUp() probably wants to set timeoutID = null before it calls finish(), right?  Since there's no point in calling clearTimeout on for a timeout that's already fired?

(I imagine that's what you intended -- otherwise, there'd be no reason to null-check timeoutID in finish(), since I think it's currently always going to be set at that point.)

r=me with that fixed.  Thanks!

        Attachment #640834 -
        Flags: review?(dholbert) → review+

    
    

    
  
Thanks Daniel, that's great.

I took the chance to fix the same bit of code in deferred-tree-1.xhtml at the same time plus a few other tweaks:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f16647509237

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f16647509237
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Comment on attachment 640834 [details] [diff] [review]
Proposed fix v1a

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Unknown
User impact if declined: Higher rate of [orange]
Testing completed (on m-c, etc.): m-c, aurora
Risk to taking this patch (and alternatives if risky): N/A, test-only fix.
String or UUID changes made by this patch: None

        Attachment #640834 -
        Flags: approval-mozilla-beta?

    
    

    
      
  

    
    

    
      
  

        Attachment #640834 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [orange]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: