707864 - select to print with no printers installed results in app crash

Status: RESOLVED WONTFIX

(Core :: Printing: Setup, defect)

Description

[Erdmann]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)

Steps to reproduce:

press print button (with no printer installed)


Actual results:

application crash


Expected results:

Error is in mozilla/widget/src/os2/nsDeviceContextSpecOS2.cpp#653 as a check is missing on if any printers are installed at all (derefencing "Elements" of a nsTArray is not allowed if array is empty).
I suggest:

void GlobalPrinters::GetDefaultPrinterName(PRUnichar*& aDefaultPrinterName)
...
nsAutoChar16Buffer printerName;
PRInt32 printerNameLength;
MultiByteToWideChar(0, printer, strlen(printer), printerName,
      printerNameLength);
if (!printerName.IsEmpty())
{
    aDefaultPrinterName = ToNewUnicode(nsDependentString(printerName.Elements()));
}
...

Same holds true (analogous) for this member function:
nsresult GlobalPrinters::InitializeGlobalPrinters ()

}

Comment 1

[Erdmann]

Forgot:
if (!printerName.IsEmpty())
{
    aDefaultPrinterName = ToNewUnicode(nsDependentString(printerName.Elements()));
}
else
{
    aDefaultPrinterName = NULL;
}

Comment 2

[Erdmann]

or rather (judging from the Windows implementation):
if (!printerName.IsEmpty())
{
    aDefaultPrinterName = ToNewUnicode(nsDependentString(printerName.Elements()));
}
else
{
    aDefaultPrinterName = "";
}

Comment 3

[Erdmann]

Attachment: Stack trace (trap log)

Comment 5

[Wayne Mery (:wsmwk)]

OS/2 is no longer a supported platform.