Closed
Bug 707870
Opened 13 years ago
Closed 13 years ago
nsDOMEventTargetHelper should Disconnect mListenerManager itself
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 1 obsolete file)
|
12.90 KB,
patch
|
smaug
:
review+
mounir
:
checkin+
|
Details | Diff | Splinter Review |
I don't know if it is expected that mListenerManager has to be disconnected by class inheriting from nsDOMEventTargetHelper but that seems a very bad design because developers writing code for those class don't know at a first glance this is needed. In addition, most usage consist of disconnecting in the inherited class dtor so we could just do that in nsDOMEventTargetHelper dtor. Disconnecting at another moment will still work.
Attachment #579212 -
Flags: review?(bugs)
|
Assignee | |
Comment 1•13 years ago
|
||
WindowRoot is actually creating its own mListenerManager instance.
Attachment #579212 -
Attachment is obsolete: true
Attachment #579212 -
Flags: review?(bugs)
Attachment #579562 -
Flags: review?(bugs)
|
||
Updated•13 years ago
|
Attachment #579562 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite-
Whiteboard: [needs review]
Target Milestone: --- → mozilla11
|
|
Assignee | |
Updated•13 years ago
|
Attachment #579562 -
Flags: checkin+
|
||
Comment 2•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/647b56f040f1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•