Closed Bug 707883 Opened 13 years ago Closed 13 years ago

Rename and move around dom/telephony to be more generic

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla11

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(4 files, 1 obsolete file)

Rename Radio -> RadioManager 13 years ago Blake Kaplan (:mrbkap) (inactive) 9.03 KB, patch	bent.mozilla : review+ mrbkap : checkin+	Details \| Diff \| Splinter Review
Move RadioManager into dom/system/b2g and make dom/telephony just telephone stuff 13 years ago Blake Kaplan (:mrbkap) (inactive) 10.80 KB, patch	bent.mozilla : review+ mrbkap : checkin+	Details \| Diff \| Splinter Review
Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback} 13 years ago Blake Kaplan (:mrbkap) (inactive) 9.39 KB, patch		Details \| Diff \| Splinter Review
Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback} 13 years ago Blake Kaplan (:mrbkap) (inactive) 10.17 KB, patch	bent.mozilla : review+ mrbkap : checkin+	Details \| Diff \| Splinter Review
Rename nsITelephonyWorker -> nsIRadioWorker 13 years ago Blake Kaplan (:mrbkap) (inactive) 6.43 KB, patch	bent.mozilla : review+ mrbkap : checkin+	Details \| Diff \| Splinter Review

Blake Kaplan (:mrbkap) (inactive)

Assignee

Description

•

13 years ago

      No description provided.

Mounir Lamouri (:mounir)

Updated

•

13 years ago

OS: Mac OS X → All

Hardware: x86 → All

Version: unspecified → Trunk

Blake Kaplan (:mrbkap) (inactive)

Assignee

Comment 1

•

13 years ago

Attached patch Rename Radio -> RadioManager — Details — Splinter Review

Attachment #579235 - Flags: review?(bent.mozilla)

Blake Kaplan (:mrbkap) (inactive)

Assignee

Comment 2

•

13 years ago

Attached patch Move RadioManager into dom/system/b2g and make dom/telephony just telephone stuff — Details — Splinter Review

Attachment #579236 - Flags: review?(bent.mozilla)

Blake Kaplan (:mrbkap) (inactive)

Assignee

Comment 3

•

13 years ago

Attached patch Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback} (obsolete) — Details — Splinter Review

Attachment #579238 - Flags: review?(bent.mozilla)

Blake Kaplan (:mrbkap) (inactive)

Assignee

Comment 4

•

13 years ago

Attached patch Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback} — Details — Splinter Review

Oops. I forgot to rename the member and function names last time around.

Attachment #579238 - Attachment is obsolete: true

Attachment #579238 - Flags: review?(bent.mozilla)

Attachment #579244 - Flags: review?(bent.mozilla)

Philipp von Weitershausen [:philikon]

Updated

•

13 years ago

Blocks: b2g-telephony

Ben Turner (not reading bugmail, use the needinfo flag!)

Updated

•

13 years ago

Attachment #579235 - Flags: review?(bent.mozilla) → review+

Ben Turner (not reading bugmail, use the needinfo flag!)

Updated

•

13 years ago

Attachment #579236 - Flags: review?(bent.mozilla) → review+

Ben Turner (not reading bugmail, use the needinfo flag!)

Updated

•

13 years ago

Attachment #579244 - Flags: review?(bent.mozilla) → review+

Blake Kaplan (:mrbkap) (inactive)

Assignee

Comment 5

•

13 years ago

Attached patch Rename nsITelephonyWorker -> nsIRadioWorker — Details — Splinter Review

So, in order to keep individual worker CIDs with their respective code, this requires workers to be accompanied by a .h file.

Attachment #579258 - Flags: review?(bent.mozilla)

Ben Turner (not reading bugmail, use the needinfo flag!)

Comment 6

•

13 years ago

Comment on attachment 579258 [details] [diff] [review]
Rename nsITelephonyWorker -> nsIRadioWorker

Excellent diff, git. Really excellent.

Attachment #579258 - Flags: review?(bent.mozilla) → review+

Blake Kaplan (:mrbkap) (inactive)

Assignee

Updated

•

13 years ago

Attachment #579235 - Flags: checkin+

Blake Kaplan (:mrbkap) (inactive)

Assignee

Updated

•

13 years ago

Attachment #579236 - Flags: checkin+

Blake Kaplan (:mrbkap) (inactive)

Assignee

Updated

•

13 years ago

Attachment #579244 - Flags: checkin+

Blake Kaplan (:mrbkap) (inactive)

Assignee

Updated

•

13 years ago

Attachment #579258 - Flags: checkin+

Philipp von Weitershausen [:philikon]

Comment 7

•

13 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcdee6d5f3e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/02621ec98be0
https://hg.mozilla.org/integration/mozilla-inbound/rev/40d6fba613a2
https://hg.mozilla.org/integration/mozilla-inbound/rev/052b784ae76b
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b850a655623
https://hg.mozilla.org/integration/mozilla-inbound/rev/09a56c8d5822

Ed Morley [:emorley]

Comment 8

•

13 years ago

https://hg.mozilla.org/mozilla-central/rev/fcdee6d5f3e5
https://hg.mozilla.org/mozilla-central/rev/02621ec98be0
https://hg.mozilla.org/mozilla-central/rev/40d6fba613a2
https://hg.mozilla.org/mozilla-central/rev/052b784ae76b
https://hg.mozilla.org/mozilla-central/rev/7b850a655623
https://hg.mozilla.org/mozilla-central/rev/09a56c8d5822

Status: ASSIGNED → RESOLVED

Closed: 13 years ago

Resolution: --- → FIXED

Target Milestone: --- → mozilla11

Philipp von Weitershausen [:philikon]

Updated

•

13 years ago

Component: DOM → DOM: Device Interfaces

QA Contact: general → device-interfaces

You need to log in before you can comment on or make changes to this bug.