708125 - OGL Layers thrashes current context in UpdateSurface and RenderLayer

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

For the shared-texture path:
In UpdateSurface we currently switch to the layer GLContext, even if it's not necessary.
In RenderLayer, we switch to the WebGL GLContext to resolve, then back again to the layer GLContext for rendering.

This is possibly adding an extra context switch, when we could be doing all the work in the WebGL GLContext before moving on to the work on the layer GLContext.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Reduce current context thrashing in OGL Layers

This also moves the UpdateSurface code for resolving the buffer back to UpdateSurface, instead of where it is now in RenderLayer.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 579520 [details] [diff] [review]
Reduce current context thrashing in OGL Layers

Review of attachment 579520 [details] [diff] [review]:
-----------------------------------------------------------------

Patch no longer necessary after bug 711649.

Comment 3

[Ed Morley [:emorley]]

Fixed by bug 711649