708191 - Don't draw when the screen is off on gonk

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Michael Wu [:mwu]]

This would help us avoid the "E/gralloc ( 3017): S3CFB_SET_VSYNC_INT enable failed" errors.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

+1

Comment 2

[Michael Wu [:mwu]]

Attachment: Don't draw when the screen is off

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 586233 [details] [diff] [review]
Don't draw when the screen is off

We're going to need to ensure we recomposite (and probably invalidate) the entire screen when we power back on, but this is a step in the right direction.  Please file a followup.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Also, we should deactivate all windows when the screen goes off.  That should incidentally prevent them from attempting to repaint as well.  ("should")  We still want this patch to deal with race conditions.

Comment 5

[Michael Wu [:mwu]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> Also, we should deactivate all windows when the screen goes off.  That
> should incidentally prevent them from attempting to repaint as well. 
> ("should")  We still want this patch to deal with race conditions.

Deactivating windows (by sending the deactivate event) doesn't stop invalidate calls AFAICT. That's why I removed the LOG("  parent isn't top window, bailing"); logging in invalidate.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Alright.  I may be thinking of docShell.active or something like that.  We'll of course need to do that work in followup too.

Comment 7

[Michael Wu [:mwu]]

Attachment: Don't draw when the screen is off, v2

This version postpones draws until the screen turns back on to make sure things are redrawn if needed.

Comment 8

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80d20ea83b92

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/80d20ea83b92