Closed
Bug 708253
Opened 13 years ago
Closed 13 years ago
Use IDL for Components.(utils.)reportError
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
8.87 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #579691 -
Flags: review?(bobbyholley+bmo)
Comment 1•13 years ago
|
||
Comment on attachment 579691 [details] [diff] [review] Patch v1 >+ [deprecated,implicit_jscontext] void reportError(in jsval error); I think we could use a space between the attributes (above as well). >+nsXPCComponents_Utils::ReportError(const JS::Value& error, JSContext* cx) The star and ampersand should be fixed (in a few other places as well). >- JSString* msgstr = JS_ValueToString(cx, argv[0]); For a second there, I thought you were naming a variable after yourself. ;-) >+ NS_ENSURE_SUCCESS(scripterr->InitWithWindowID( >+ reinterpret_cast<const PRUnichar *>(msgchars), >+ NS_ConvertUTF8toUTF16(fileName).get(), >+ nsnull, lineNo, 0, 0, "XPConnect JavaScript", innerWindowID), >+ NS_OK); I'm not really a fan of this, because I find it jarring to see non-error-handing code wrapped up on an NS_ENSURE_* macro. I'd prefer to use an rv, and do NS_ENSURE_SUCCESS(rv, NS_OK). r=bholley with that.
Updated•13 years ago
|
Attachment #579691 -
Flags: review?(bobbyholley+bmo) → review+
Assignee | ||
Comment 2•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b456317ba3e4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•