708788 - Add telemetry probes for new/close tab animations

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

As requested by product (see https://etherpad.mozilla.org/desktop-responsiveness) add a telemetry probe for new tab and closed tab animations.

Comment 1

[Dietrich Ayala (:dietrich)]

Is this to measure the time spent solely animating, as distinct from the full time to open/close a tab?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

It might be useful to track the time in between returning from removeTab, and _endRemoveTab (the end of the animation), to detect how much it varies from the specified animation time in practice.

Comment 3

[Asa Dotzler [:asa]]

yes, I want to know whether or not we're actually getting the user experience we've specified in the CSS. I'll have separate bugs for tuning that transition timing in the css.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

I don't know if my histogram definitions make sense -- when should LINEAR be used and what motivates the bucket size?

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 581634 [details] [diff] [review]
patch

Review of attachment 581634 [details] [diff] [review]:
-----------------------------------------------------------------

code changes look fine. per Taras comment on other telemetry patch, should add the unit (eg: "_MS" or something) to the histogram name.

wrt to the maximum value - you should do some timings in a few different environments to see what the values look like to see what high/low values you get. we can also adjust later if the in-the-wild values are radically different.

wrt to buckets - i don't really know. am not sure about why/where it's important to have more or less buckets. maybe when variation in results is quite high?

Comment 6

[(dormant account)]

Comment on attachment 581634 [details] [diff] [review]
patch

I don't see value in measuring up to 3 seconds of tab anim, but up to you. Please add _MS to histogram names that measure milliseconds

Comment 7

[Dão Gottwald [:dao]]

3 seconds is the time after which tabbrowser gives up waiting for the animation to finish and forcefully removes the tab. Some users seem to still hit that limit.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5c428813b210

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/5c428813b210

Comment 10

[Dietrich Ayala (:dietrich)]

Already paying back. Looks like this caught a regression between fx9 and fx10: bug 724349.