708946 - Refactor accountportal to use mozsvc.user

Status: VERIFIED FIXED

(Cloud Services :: Server: Account Portal, defect)

Description

[Ryan Kelly [:rfkelly]]

Attachment: patch refactoring accountportal to use mozsvc.user

This uses the new mozsvc.user module to simplify the auth-management code in account portal.  The automatically-loaded auth backend is available at request.registry["auth"], while the AuthenticationPolicy becomes a pretty simple wrapper around mozsvc.user.authenticate().

Comment 1

[Toby Elliott [:telliott]]

Comment on attachment 580288 [details] [diff] [review]
patch refactoring accountportal to use mozsvc.user

We probably want to put the CEF logging back for a bad username and password combo, but otherwise looks fine.

Note that authenticated_userid now returns the id rather than the username. Since I don't think we're using that anywhere, I don't think it's a problem, but should keep an eye on that.

Comment 2

[Ryan Kelly [:rfkelly]]

> We probably want to put the CEF logging back for a bad username and password combo

This is done inside mozsvc.user.authenticate().

> Note that authenticated_userid now returns the id rather than the username.

Hmmm, quite right.  Most of the pyramid auth plugins I've seen have returned the username from this method, so I think that's the right thing to do here.  Definitely something to keep an eye on.

Committed in http://hg.mozilla.org/services/account-portal/rev/bb631007e482