709005 - Sync the browser.sessionstore.restore_on_demand pref

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Philipp von Weitershausen [:philikon]]

The browser.sessionstore.restore_on_demand pref is exposed in the UI in Firefox 8+, but unlike the other exposed session restore related prefs, it's not synced. We should fix this.

Also, for future reference, here's a general rule: if you're introducing a pref that (a) is exposed to the user in the UI, (b) is cross platform, and (c) something you would expect to sync across profiles and/or related to prefs that are already synced: add it to the list of synced prefs!

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

I can fix [good first bug]s too

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.2

derp. I can even attach patches that don't have other junk in them.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 580489 [details] [diff] [review]
Patch v0.2

Review of attachment 580489 [details] [diff] [review]:
-----------------------------------------------------------------

Does what it says on the tin!

Please write up brief steps for QA to verify.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Landed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/8e9120a2a121

For QA to verify: check the "don't load tabs until selected" box in the general pref pane. Make sure that gets synced to a second machine.

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/8e9120a2a121