Closed Bug 709081 Opened 13 years ago Closed 13 years ago

[code quality] Use get_user() in Elastic tests rather than hard-coded IDs

Categories

(support.mozilla.org :: Search, defect, P3)

Product:
support.mozilla.org
Component:
Search
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2012-01-17

People

(Reporter: erik, Assigned: erik)

Details

(Whiteboard: u=dev c=search s=2012.1 p=1 [qa-]) 

Use users.tests.get_user() instead of hard-coding 118533. It just so happens that get_user() is specced to return that exact user.
This is easy pickins.  Might as well do it now before we copy-and-paste all that code over and over again and make the code sillier.
Whiteboard: u=user c=search s=2012.1 p=
Whiteboard: u=user c=search s=2012.1 p= → u=user c=search s=2012.1 p=1
Grabbing this before we do more ES tests.
Assignee: nobody → willkg
ES tests use model makers now, so this is m00t.

Marking as WONTFIX since there's nothing to do here.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
I missed the app-specific ES tests.  This is still a problem with questions/tests/test_es.py and forums/test/test_es.py.

Reopening.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Grabbing after talking to Will. I needed this to happen so I could kill the mixins and fixtures in the ES tests.
Assignee: willkg → erik
...which I need to happen so I can write decent tests for bug 710469.
Fixed in http://github.com/mozilla/kitsune/commit/cc9b4c826648c2dfec4f74972d4e7ea017c9d3a8.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Pretty sure this lands in 2012-01-17.
Target Milestone: --- → 2012-01-17
Whiteboard: u=user c=search s=2012.1 p=1 → u=dev c=search s=2012.1 p=1
Please add QA verification steps, or mark as [qa-], thanks
The tests verify this sufficiently. (Let see if the sprint graphs trip over this.)
Whiteboard: u=dev c=search s=2012.1 p=1 → u=dev c=search s=2012.1 p=1 [qa-]
Closed as [qa-]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.