Closed Bug 709182 Opened 13 years ago Closed 12 years ago

"connecting" in tab title when reloading is unnecessary visual noise

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 13

People

(Reporter: dietrich, Assigned: jaws)

References

Details

(Whiteboard: [Snappy:P1])

Attachments

(1 file)

Limi: "connecting" in the title of a tab while reloading should be removed, it's visual noise that makes it seem slower.
Whiteboard: [snappy]
Whiteboard: [snappy] → [Snappy:P1]
Whiteboard: [Snappy:P1] → [Snappy:P1][good first bug]
Whiteboard: [Snappy:P1][good first bug] → [Snappy:P1]
Assignee: nobody → thomas
OS: Mac OS X → All
Hardware: x86 → All
Assignee: thomas → nobody
Attached patch Patch for bugSplinter Review
I need to push it to tryserver tomorrow, as I'm pretty sure this will break some tests.
Assignee: nobody → jwein
Status: NEW → ASSIGNED
Whiteboard: [Snappy:P1] → [Snappy:P1][autoland]
Whiteboard: [Snappy:P1][autoland] → [Snappy:P1][autoland-in-queue]
Autoland Patchset:
	Patches: 597297
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=27dfc588401d
Try run started, revision 27dfc588401d. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=27dfc588401d
Try run for 27dfc588401d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=27dfc588401d
Results (out of 211 total builds):
    success: 181
    warnings: 16
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-27dfc588401d
Whiteboard: [Snappy:P1][autoland-in-queue] → [Snappy:P1]
Comment on attachment 597297 [details] [diff] [review]
Patch for bug

The try run was green, so I'm moving this forward for review.
Attachment #597297 - Flags: review?(ttaubert)
Version: unspecified → Trunk
Comment on attachment 597297 [details] [diff] [review]
Patch for bug

Review of attachment 597297 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but I'm not too familiar with this code. Asking Dão for review to be on the safe side here.
Attachment #597297 - Flags: review?(ttaubert)
Attachment #597297 - Flags: review?(dao)
Attachment #597297 - Flags: review+
Attachment #597297 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/f2267cb4330f
Whiteboard: [Snappy:P1] → [Snappy:P1][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f2267cb4330f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [Snappy:P1][fixed-in-fx-team] → [Snappy:P1]
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: