Closed
Bug 709195
Opened 13 years ago
Closed 13 years ago
Include CEF logging library in Playdoh
Categories
(mozilla.org Graveyard :: Webdev, task)
mozilla.org Graveyard
Webdev
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wenzel, Assigned: wenzel)
Details
The CEF logging library should be included in Playdoh (I can do that). Wil, can you point out what component we need to snag from AMO again to hook this into Django better? Also, do you have a suggestion where this should go? Funfactory or its own library somewhere, or even straight into the CEF lib? Developer documentation forthcoming from yvan and rforbes.
Assignee | ||
Comment 1•13 years ago
|
||
All right I got most of the information I needed from bug 690286. I chose to use the `logging` facility since we use that everywhere for logging, rather than using the `syslog` module that cef uses by default. Two separate logging facilities would otherwise be fun to maintain in playdoh. This was great to figure out. r? please, clouserw? https://github.com/mozilla/funfactory/commit/3ef392d https://github.com/mozilla/playdoh/commit/55a11f6 https://github.com/mozilla/playdoh-docs/commit/48a408f
Assignee: nobody → fwenzel
Whiteboard: [r?clouserw]
Assignee | ||
Comment 2•13 years ago
|
||
Thanks, Wil. I worked through the comments you made. Here are the tweaks: https://github.com/mozilla/playdoh/commit/7a5f0b4 https://github.com/mozilla/funfactory/commit/e7d28b0
Assignee | ||
Comment 3•13 years ago
|
||
All right thanks for the reviews, Wil. Landed: https://github.com/mozilla/funfactory/commit/8d7944f https://github.com/mozilla/playdoh-lib/commit/2f84cbb https://github.com/mozilla/playdoh/compare/50f39d3...b48e29c https://github.com/mozilla/playdoh-docs/commit/65e8c1c This is all I think I can do from my side at the moment. Please let me know if you have additional documentation that you'd like to land etc.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [r?clouserw]
Updated•6 years ago
|
Product: mozilla.org → mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•