709205 - use services::GetObserverService instead of do_GetService

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Several do_GetService(NS_OBSERVERSERVICE_CONTRACTID) calls have snuck in over time; the incoming patches replace them with their equivalent, mozilla::services::GetObserverService.  There are still a couple two-argument do_GetService(NS_OBSERVERSERVICE_CONTRACTID, &rv) calls lying about; I chose not to handle those in this patchset.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use GetObserverService in docshell, dom

Simple patch for docshell and dom.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: use GetObserverService in places

Simple patch for places.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: use GetObserverService in xpcom

Simple patch for xpcom.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 580484 [details] [diff] [review]
use GetObserverService in docshell, dom

r=me

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 580485 [details] [diff] [review]
use GetObserverService in places

Review of attachment 580485 [details] [diff] [review]:
-----------------------------------------------------------------

In both places you may use just services:: since those files already have using namespace mozilla;

Comment 6

[Nathan Froyd [:froydnj]]

Attachment: use GetObserverService in places

Adjusted to account for mak's comments and drive-by-fixes to other mozilla::services:: instances in the touched files.  Mak approved the drive-by-fixes on IRC.  Carrying over r+.

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f8dd0388d87
https://hg.mozilla.org/integration/mozilla-inbound/rev/da1b38aa2886
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbd797fc4d7f

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/8f8dd0388d87
https://hg.mozilla.org/mozilla-central/rev/da1b38aa2886
https://hg.mozilla.org/mozilla-central/rev/cbd797fc4d7f