Closed Bug 70929 Opened 23 years ago Closed 23 years ago

refactor nsIGlobalHistory

Categories

(Core Graveyard :: History: Global, defect, P2)

Product:
Core Graveyard
Component:
History: Global
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: alecf, Assigned: alecf)

References

Details

(Keywords: embed, Whiteboard: fix in hand)

Attachments

(1 file)

How does this look?
10.73 KB, patch
Details | Diff | Splinter Review 
We need to refactor nsIGlobalHistory to make it easy for embedders to
reimplement a super-light history, for simple stuff like link coloring.
Status: NEW → ASSIGNED
Keywords: embed
Priority: -- → P2
Target Milestone: --- → mozilla0.9
Blocks: 70229

    
    

    
  
don't worry about the slight rdf changes in nsGlobalHistory.cpp - I won't check
them in

    
    

    
  
cc'ing waterson, my history-review-bitch
Whiteboard: fix in hand

    
    

    
  
This looks good. r=waterson

    
    

    
  
I'm looking in to providing a common interface for session and global history to
access elements like URI, title and a enumerator so that an embeddor can
provide his own UI for global and session History.  I have proposed some ideas
in  news://news.mozilla.org/3A9C3DD6.2000501@netscape.com and
news://news.mozilla.org/3AA03A3A.5040906@netscape.com.

The patch attached here is taking us closer to what is posted there. Please take
a look at it and provide your inputs.


    
    

    
  
cool. fix is in.. thanks for the pointers radha, I'll take a look
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
code-level fix, waiving my hands and marking VERIFIED Fixed

Status: RESOLVED → VERIFIED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: