709432 - BrowserProvider overwrites provided GUIDs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

… unconditionally. This makes Sync a little harder :D

The attached patch is pretty trivial, but untested.

Throwing this at blassey, but I'd be happy with any peer to review it.

Comment 1

[Richard Newman [:rnewman]]

Tree is closed right now, so I've asked jvoll to just work with this in his local build so he's unblocked. But this is blocking our local DB repo for bookmarks.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 580610 [details] [diff] [review]
Proposed patch. v1

Review of attachment 580610 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/BrowserProvider.java
@@ +929,5 @@
>                  History.URL + " IS NOT NULL)";
>  
>          return db.delete(TABLE_IMAGES, selection, null);
>      }
> +}

not sure if you added or removed the new line here, just make sure its the former

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/5c64fb241d4e