Closed Bug 709486 Opened 13 years ago Closed 13 years ago

"Warning: Ignoring obsolete chrome registration modifier 'xpcnativewrappers=no'" message in error console should not contain the prefix "Warning"

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla12

People

(Reporter: aceman, Assigned: aceman)

Details

(Keywords: polish)

Attachments

(1 file)

patch
1.01 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
The severity of the message (warning) is already shown by the icon. Also, when copying this message into clipboard, the text representation gets another "Warning: " prefix before the text. The pasted result is then:

Warning: Warning: Ignoring obsolete chrome registration modifier 'xpcnativewrappers=no'.
Source File: jar:file:///.../.thunderbird/nightly.default/extensions/inspector@mozilla.org.xpi!/chrome.manifest
Line: 17
Attached patch patch — — Splinter Review 
Assignee: nobody → acelists
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

        Attachment #580658 -
        Flags: review?(shaver)

    
  
Assignee: acelists → nobody
Component: XUL → XPCOM
QA Contact: xptoolkit.widgets → xpcom

    
  
Assignee: nobody → acelists

    
  

        Attachment #580658 -
        Flags: review?(benjamin)

    
  

        Attachment #580658 -
        Flags: review?(shaver)

        Attachment #580658 -
        Flags: review?(benjamin)

        Attachment #580658 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
Thanks for the patch! Landed:
https://hg.mozilla.org/mozilla-central/rev/8ffdb4c7404a

Also -- in the future, it'd be awesome if you could set up hg to tag you as the author in your patches (and also a commit message, ideally), as described here:
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f

Thanks again!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

    
    

    
  
Yes, I do that, but this patch was created before I started doing it.

    
    

    
  
Ah, great then. :)

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: