Closed
Bug 709562
Opened 13 years ago
Closed 13 years ago
nsAutoDialWin does not need to load rasapi32/rasdlg dynamically
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(2 files)
|
15.91 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
|
886 bytes,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Current Gecko doesn't run on Windows 9x and NT4.0. So it is unnecessary to use LoadLibrary for rasapi32.dll and rasdlg.dll.
Summary: nsAutoDialWin is unnecessary to load rasapi32/rasdlg dynamically → nsAutoDialWin does not need to load rasapi32/rasdlg dynamically
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → m_kato
Attachment #580822 -
Flags: review?(jmathies)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 580822 [details] [diff] [review] fix Presumably this is to help bug 709193? This looks fine.
Attachment #580822 -
Flags: review?(jmathies) → review+
|
||
Comment 3•13 years ago
|
||
Did the patch land?
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #583091 -
Flags: review?(taras.mozilla)
|
||
Updated•13 years ago
|
Attachment #583091 -
Flags: review?(taras.mozilla) → review?(khuey)
Attachment #583091 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ed882263c14 https://hg.mozilla.org/integration/mozilla-inbound/rev/6c8e6f6a8ac8
Whiteboard: [inbound]
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6ed882263c14 https://hg.mozilla.org/mozilla-central/rev/6c8e6f6a8ac8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•