709747 - Support nsCOMPtr<T>::forget(I**)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

As in bug 489705.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I love you.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 580873 [details] [diff] [review]
Patch v1

Wait, the reason the old code called swap on a temp ptr was for comptr logging. Your current patch skips all that. Are you sure this won't mess up the comptr logging scripts?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/82bc89d8e3c3

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Ms2ger, you didn't address comment 2. Do our leak scripts handle this?

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No idea.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, I think this needs to use NSCAP_LOG_RELEASE to make nsCOMPtr logging work again.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Fix the COMPtr logging

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 637311 [details] [diff] [review]
Fix the COMPtr logging

r=dbaron

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/027b86239bf3

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Er, ugh, now that I look again, we shouldn't have made the second change, since nsCOMPtr<nsISupports>::forget(nsISupports**) uses swap().

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Previous patch half backed out in https://hg.mozilla.org/mozilla-central/rev/f08d285b63b0 , so things should now be good.