Closed
Bug 709977
Opened 13 years ago
Closed 13 years ago
Don't use xpc_qsAString in IDB Key.h
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
SetFromJSVal is currently the only user of xpc_qsAString outside of XPConnect. Except for the additional API exposed, there are two problems with that. First, we don't check if IsValid() before using the string, which could (if I'm not mistaken, I may be) lead to dereferencing uninitialized memory in case of OOM, and second, there's really no need to invoke all the generic value -> string conversion code, because we already know we've got a string. Fortunately, it can easily be replaced by nsDependentJSString.
Attachment #581063 -
Flags: review?(bent.mozilla)
|
||
Updated•13 years ago
|
Attachment #581063 -
Flags: review?(bent.mozilla) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d6a97d9eb14b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•