Closed
Bug 710103
Opened 13 years ago
Closed 13 years ago
Update XPCShell tests for GfxInfo blocklisting
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: drs, Assigned: drs)
References
Details
Attachments
(1 file, 1 obsolete file)
49.60 KB,
patch
|
drs
:
review+
|
Details | Diff | Splinter Review |
Following changes to GfxInfo in 706702, xpcshell tests and their associated spoofing API are now out of date. These must be updated to support new string-based (non-hex) vendor and device ID's. Additionally, the semantics of each platform are now different, so we have to spoof things in different ways depending on the platform that they're running on.
Assignee | ||
Comment 1•13 years ago
|
||
Also snuck in some fixes for Linux adapter device/vendor getting and spoofing.
Assignee: nobody → dsherk
Attachment #581196 -
Flags: review?(joe)
Assignee | ||
Comment 2•13 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=6636376b8c90
Comment 3•13 years ago
|
||
Comment on attachment 581196 [details] [diff] [review] Patch v1.0, update XPCShell tests for GfxInfo blocklisting. Review of attachment 581196 [details] [diff] [review]: ----------------------------------------------------------------- My only real concern is about the DirectX checks you added in GfxInfoX11. Do you really need them? ::: toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_DriverNew.js @@ +52,5 @@ > + case "Linux": > + do_test_finished(); > + return; > + case "Darwin": > + do_test_finished(); Add comments here (and in all js files) - "// We don't support driver versions on..." ::: widget/public/nsIGfxInfoDebug.idl @@ +38,5 @@ > #include "nsISupports.idl" > > /* NOTE: this interface is only implemented in debug builds */ > > [scriptable, uuid(0c19c88a-9ef1-4bb4-b0a2-86ab768e8bd6)] Should change the UUID here, not that it matters ::: widget/src/xpwidgets/GfxInfoX11.cpp @@ +282,5 @@ > #endif > > // Don't evaluate any special cases if we're checking the downloaded blocklist. > + // Never check DirectX because it's never relevant to Linux, and we use it in > + // the XPCShell tests. Hm, I'm not too fussy about adding these checks. Shouldn't the feature be silently ignored?
Attachment #581196 -
Flags: review?(joe) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Addressed code review comments, r+ carried (see bug 710432 for more code review).
Attachment #581196 -
Attachment is obsolete: true
Attachment #581528 -
Flags: review+
Assignee | ||
Comment 5•13 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=864451bfe1b9
Assignee | ||
Comment 6•13 years ago
|
||
https://tbpl.mozilla.org/?rev=fe937bac6e75
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe937bac6e75
Target Milestone: --- → mozilla11
Comment 8•12 years ago
|
||
Backed out from beta only: http://hg.mozilla.org/releases/mozilla-beta/rev/ec62feca7f74 See Bug 711656 for explanation.
You need to log in
before you can comment on or make changes to this bug.
Description
•