Closed
Bug 710152
Opened 13 years ago
Closed 13 years ago
GCLI javascript completion should stop providing completions with 'complex' JS input
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
Attachments
(1 file)
|
6.92 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
Currently the completion proposal for: > console.log( is: console.log(console Which, while being a possible input, is clearly quite unlikely. In fact the likely inputs here are hard to predict. Also the completion proposal for: > [1, 2, 3].forEach(function(i) { Depends on the value of the second parameter to the forEach function. Something that we currently ignore, and will be hard to get right given that it hasn't been typed yet. So we should give up providing completions when the input contains something other than alphanumerics and dots.
|
Assignee | |
Updated•13 years ago
|
Component: Developer Tools → Developer Tools: Console
QA Contact: developer.tools → developer.tools.console
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
a.k.a https://github.com/campd/gcli/pull/12
Attachment #581320 -
Flags: review?(dcamp)
|
||
Updated•13 years ago
|
Attachment #581320 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ea2996a1f3c
Whiteboard: [landed-in-fxteam]
|
||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/62cca592625d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [landed-in-fxteam]
Target Milestone: --- → Firefox 12
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•