710393 - NoSuchMethodError: java.lang.Math.copySign

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

I loaded www.google.com/webfonts on the Droid Pro using an m-c build from today (December 13), rotated, and tried to pan. Fennec crashed with the following in logcat:

12-13 16:58:34.650  2351  2351 E AndroidRuntime: FATAL EXCEPTION: main
12-13 16:58:34.650  2351  2351 E AndroidRuntime: java.lang.NoSuchMethodError: java.lang.Math.copySign
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at org.mozilla.gecko.ui.PanZoomController$Axis.advanceFling(PanZoomController.java:779)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at org.mozilla.gecko.ui.PanZoomController$FlingRunnable.run(PanZoomController.java:627)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:587)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:92)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:143)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at org.mozilla.gecko.GeckoApp$26.run(GeckoApp.java:1372)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:587)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:92)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:143)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:4717)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at java.lang.reflect.Method.invokeNative(Native Method)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Method.java:521)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
12-13 16:58:34.650  2351  2351 E AndroidRuntime: 	at dalvik.system.NativeStart.main(Native Method)

Apparently the method was added in API version 9, and the Droid Pro is running Android 2.2 (API version 8), so it doesn't have that function.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Stop using copysign

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 581697 [details] [diff] [review]
Stop using copysign

Review of attachment 581697 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Stop using copysign (v2)

Updated so we don't fall into this case for Math.pow:

 pow((-anything except 0 and inf), (non-integer)) = NAN

and end up with NaNs all over the place.

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 581710 [details] [diff] [review]
Stop using copysign (v2)

Review of attachment 581710 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, looks good.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Landed on m-c since pcwalton seems to be gone and may or may not land his bug 710119 patch today, and this really needs to be fixed.

https://hg.mozilla.org/mozilla-central/rev/41f75cbb91f2

Comment 8

[Aaron Train [:aaronmt]]

Motorola Droid Pro (Android 2.3)
20111215075015
http://hg.mozilla.org/mozilla-central/rev/bbb2149b613e