710472 - test_waitForPageLoad.js looks for something that doesnt exist

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

https://github.com/mozautomation/mozmill/blob/master/mutt/mutt/tests/js/test_waitForPageLoad.js#L13

Sure enough, there doesn't seem to be an ID getMeOutOfHereButton on
that page.

I vote we remove the line.

Really, test_waitForPageLoad.js should be broken up.  I'm happy to
file a more thorough bug on this separately if desired.

Comment 1

[Jeff Hammel]

Attachment: disable url that doesn't have the element on it

guessing this will be needed on 2.0 as well but for now i mostly need this on master

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 581488 [details] [diff] [review]
disable url that doesn't have the element on it

Those pages have been moved to mozilla.org. Simply use http://www.mozilla.org/firefox/its-a-trap.html for the test.

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 581488 [details] [diff] [review]
disable url that doesn't have the element on it

Review of attachment 581488 [details] [diff] [review]:
-----------------------------------------------------------------

I have no idea how this test was passing before, but the button seems to live at www.mozilla.com/firefox/its-a-trap.html and the id has changed to 'getMeOutButton'

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Adjust button to correct url/id

This works for me, if it works for you I'll commit.

Comment 5

[Jeff Hammel]

(In reply to Andrew Halberstadt [:ahal] from comment #4)
> Created attachment 581642 [details] [diff] [review]
> Adjust button to correct url/id
> 
> This works for me, if it works for you I'll commit.

Yep wfm

Comment 6

[Andrew Halberstadt [:ahal]]

master: https://github.com/mozautomation/mozmill/commit/3886197ad6817e65db543be1b0d077f26d3a130f