710774 - Qt needs to dispatch DID_PAINT events

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 598482 comment 79.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Widget Wil/Did Paint

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 606923 [details] [diff] [review]
Widget Wil/Did Paint

Review of attachment 606923 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/qt/nsWindow.cpp
@@ +1061,5 @@
> +    {
> +        nsEventStatus status;
> +        nsPaintEvent willPaintEvent(true, NS_WILL_PAINT, this);
> +        willPaintEvent.willSendDidPaint = true;
> +        DispatchEvent(&willPaintEvent, status);

Is it really safe to change widget geometry here (and where you call DispatchDidPaint)?

@@ +1103,5 @@
>  #endif //MOZ_ENABLE_QTMOBILITY
>  
> +        status = DispatchEvent(&event);
> +        DispatchDidPaint(this);
> +        aPainter->beginNativePainting();

maybe this should be "endNativePainting"?

And maybe that should happen before DispatchDidPaint?

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Widget Wil/Did Paint

Fixed endNativePainting.

> Is it really safe to change widget geometry here
Did not get why geometry should change here?
> (and where you call DispatchDidPaint)?
I call it at the end of GL painting and at the end of DoPaint (software rendering)

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Widget Wil/Did Paint

Err, forgot to fix order

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 606938 [details] [diff] [review]
Widget Wil/Did Paint

Review of attachment 606938 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/qt/nsWindow.cpp
@@ +1233,5 @@
>      }
>  
>      ctx = nsnull;
>      targetSurface = nsnull;
> +    DispatchDidPaint(this);

You're not setting willSendDidPaint to true for this paint event.

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Widget Wil/Did Paint

Added WillSendDidPaint flag to software paint.
Also not sure what to do about geometry changed in this case... I guess nothing bad should happen
Is there are test related to this move/size during paint?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I can't remember. It doesn't happen much anymore since we got rid of almost all child widgets.

Comment 8

[Oleg Romashin (:romaxa)]

Comment on attachment 606949 [details] [diff] [review]
Widget Wil/Did Paint

Ok, hopefully we can survive with that

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d548cc64e028

Comment 10

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/d548cc64e028