710835 - Form autocomplete popup list flickers as you type

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[:Margaret Leibovic]

Follow-up from bug 695444 comment 14.

Comment 1

[Martijn Wargers (dead)]

Steps to reproduce:
- Go to http://people.mozilla.org/~mwargers/tests/autocomplete_forms/textinput_form.html
- Tap on the input, type 'abc' and submit the form
- Tap on the input again
- Now type 'b' a couple of times

Notice how the form autocomplete popup keeps appearing and disappearing on every keystroke.

Comment 4

[:Margaret Leibovic]

Changing this to a P2, since I duped bug 711181 to it and that's a P2.

I feel like one patch should fix all the popup flicker problems, but I still have to look into exactly what we need to change.

Comment 5

[:Margaret Leibovic]

Attachment: patch

I'm not quite sure why we decided to listen for composition* events instead of input events when we first implemented this - my guess is that input events weren't working properly at the time. In any case, this avoids lots of the problems we were having with compositionupdate events (wrong data strings, firing at the wrong times, etc).

The only issue I see with this is that the popup with suggestions doesn't appear when you first focus the text box, but that's not working right now anyway - we can fix that in another bug.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 587533 [details] [diff] [review]
patch

Glad to see this is working

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad341c2f7cdf

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ad341c2f7cdf

Comment 9

[Martijn Wargers (dead)]

Thanks, I verified this is indeed fixed in today's native Fennec build. Also bug 711181 is indeed fixed now, so it was indeed a duplicate.

Comment 10

[:Margaret Leibovic]

Comment on attachment 587533 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: form autocomplete popups will continue to have lots of problems
Testing completed (on m-c, etc.): verified on Nightly
Risk to taking this patch (and alternatives if risky): input events could have problems again, but they're in a much better state than composition events right now

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 587533 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/286038d5a00d