711199 - Replace menu icon images

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Ian Barlow (:ibarlow)]

Attachment: menu icons

Please replace the current bottom menu icons in GB / Froyo phones with these new and more visually consistent ones. Thanks!

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Since the new icons are for both Froyo (v8) and Gingerbread (v9), we no longer need separate icon files for v9.

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 587756 [details] [diff] [review]
patch

Review of attachment 587756 [details] [diff] [review]:
-----------------------------------------------------------------

The new icons work fine on both white and black backgrounds, right?

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c75c08fdf2c3

(In reply to Lucas Rocha (:lucasr) from comment #2)
> The new icons work fine on both white and black backgrounds, right?

Yes.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 587756 [details] [diff] [review]
patch

[Approval Request Comment]
Android-only, image-only patch that just provides some theme polish.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/c75c08fdf2c3

Comment 6

[Aaron Train [:aaronmt]]

Verified on Nightly (12.0a1)
Samsung Nexus S (Android 4.0.3)
20120113052739
http://hg.mozilla.org/mozilla-central/rev/790cd9bba7f5

Comment 7

[Aaron Train [:aaronmt]]

^ Whoops, above was tested on Galaxy SII (Android 2.3.4) Gingerbread

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 587756 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b9b826d27871