711273 - rm cruft: JS_REQUIRES_STACK, find-child.py, jsstack.js, fallibility of PutBlockObject/UnwindScope

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: rm cruft

I'm afraid this is a bit of a grab bag of cruft removal.  It started with evilpie's (evilpies'?) observation that PutBlockObject/UnwindScope really aren't fallible and then I kept finding cruft.

  17 files changed, 66 insertions(+), 584 deletions(-)

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

CC'ing Tom: what's the appropriate possessive plural for evilpie?

Comment 2

[Luke Wagner [:luke]]

Attachment: rm cruft 2

lil' bit more.

Comment 3

[Luke Wagner [:luke]]

Attachment: rm cruft 3

One more ounce of cruft (dead comment).

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 582161 [details] [diff] [review]
rm cruft 3

Review of attachment 582161 [details] [diff] [review]:
-----------------------------------------------------------------

http://www.youtube.com/watch?v=mUP3A9imOYU

::: js/src/jsobj.h
@@ +1500,5 @@
>  
>  #define OBJ_BLOCK_COUNT(cx,obj)                                               \
>      (obj)->propertyCount()
>  #define OBJ_BLOCK_DEPTH(cx,obj)                                               \
> +    ((uint32)(obj)->getFixedSlot(JSSLOT_BLOCK_DEPTH).toInt32())

uint32_t, and a C++ cast.

Comment 5

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff43da616be

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/6ff43da616be