Closed Bug 711341 Opened 13 years ago Closed 13 years ago

Tilt should give focus back to Highlighter when closed

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11+ verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 + verified

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [tilt][fixed-in-fx-team][qa+][qa!:11])

Attachments

(1 file)

v1
2.27 KB, patch
rcampbell
: review+
christian
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
Whiteboard: [tilt]
Assignee: nobody → vporof
Attached patch v1 — — Splinter Review 

        Attachment #582194 -
        Flags: review?(rcampbell)

    
    

    
  
Depends on bug 710750 because of an "instance" param added to onTiltOpen in head.js for testing to work properly.
Depends on: 710750

        Attachment #582194 -
        Flags: review?(rcampbell) → review+

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 582194 [details] [diff] [review]
v1

This restores focus on the content window when tilt is closed. Leaves you where you were before you made everything go all tilty! Would be nice in aurora...

        Attachment #582194 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9aa0f5842d75
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

    
    

    
  
Comment on attachment 582194 [details] [diff] [review]
v1

[triage comment]
Approved for aurora. While this probably wouldn't meet our criteria at the end of a cycle ("nice to have", feature works fine without, etc). We are early in the cycle and the risk looks low to take this for what will likely be a banner feature.

        Attachment #582194 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Verified on Firefox 11 & Firefox 12
Status: RESOLVED → VERIFIED

    
  
Whiteboard: [tilt][fixed-in-fx-team] → [tilt][fixed-in-fx-team][qa+]

    
    

    
  
Verified using Firefox 11 Beta 4 on Win XP, Mac OS X 10.6 and Ubuntu 11.10 - focus is on the Highlighter after Tilt is closed.

Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0

          status-firefox11:
          fixed → verified
Whiteboard: [tilt][fixed-in-fx-team][qa+] → [tilt][fixed-in-fx-team][qa+][qa!:11]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: