Closed
Bug 711478
Opened 13 years ago
Closed 13 years ago
Windows PGO builds building without profiling data
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla11
People
(Reporter: ted, Assigned: Gavin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
846 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
bug 696436 made an inadvertent change that made us run the PGO profiling run from $(DIST)/bin instead of from $(DIST)/firefox like we're supposed to. This means that we don't actually get any of the profiling data into the optimizer. http://hg.mozilla.org/mozilla-central/rev/6b18f5259de9#l14.12 (This broke because we expect the PGC files to wind up in $(DIST)/firefox, so we do: rm -f ./dist/bin/*.pgc find ./dist/firefox -name "*.pgc" -exec mv {} ./dist/bin Ed Morley noticed this while looking at the results from bug 710712. We need to fix that hunk of the patch.
Assignee | ||
Comment 1•13 years ago
|
||
I just didn't realize that this was overriding the value from the included file.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #582308 -
Flags: review?(ted.mielczarek)
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 582308 [details] [diff] [review] patch Review of attachment 582308 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, let's just do this.
Attachment #582308 -
Flags: review?(ted.mielczarek) → review+
Reporter | ||
Comment 3•13 years ago
|
||
Also, I totally missed this in reviewing your original patch, so this falls on me too.
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3749f921ee90
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•