711671 - Rename nsTelephonyWorker / nsITelephone to nsIRadioInterfaceLayer

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

nsITelephone / nsTelephonyWorker is somewhat of a misnomer. First, it's not a worker itself, it just talks to a worker and exposes it (via nsIRadioWorker). Functionality-wise, it does more than just calls (SMS, data calls, network status -- we're in the process of adding all these now). API-wise it doesn't really provide much abstraction over the RIL, it's merely glue between the worker and the DOM.

So let's call it what it is: the RadioInterfaceLayer.

Comment 1

[Philipp von Weitershausen [:philikon]]

Oh, and all the RIL-stuff (nsIRadioInterfaceLayer, the RadioInterfaceLayer.js component, and ril_worker.js) should also move to from dom/telephony to dom/system/b2g IMHO (see above argument about not just being about telephony anymore).

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Here's a stab at making this better. It's now SystemWorkerManager, since it will manage workers that are owned by system components. This also uses the GetInterface stuff that mrbkap and I have discussed in the past.

We can bikeshed more on the name later, but this is the interface we want I think. Comments and disagreements welcome (always).

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 585122 [details] [diff] [review]
Patch, v1

First off, having skimmed it only briefly, I agree with this patch! But this isn't quite what I had in mind for this bug. I thought the bug summary was kinda clear, but I guess it wasn't. (Way to hijack my bug, bent! :p)

I'm happy to consider this patch part 1 and do the nsITelephone -> nsIRadioInterfaceLayer renaming in part 2 (which I'm happy to write.)

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 585122 [details] [diff] [review]
Patch, v1

Oops. It was late and I didn't really read the bug, was just looking for 'rename' in the summary. You're right, this isn't the bug I want.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Moved the patch to bug 714459.

Comment 6

[Philipp von Weitershausen [:philikon]]

<3

Comment 7

[Philipp von Weitershausen [:philikon]]

Comment on attachment 585122 [details] [diff] [review]
Patch, v1

This stuff landed in the other bug.

Comment 8

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Completely mechanical rename of the interfaces and relocation of RIL-specific stuff to dom/system/b2g, as discussed in previous comments.

Comment 9

[Philipp von Weitershausen [:philikon]]

Attachment: v2

Forgot to qrefresh... This version of the patch actually compiles ;)

Comment 10

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bb96b5ee587

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3bb96b5ee587