71182 - QNX photon port requires changes to run 4x netscape plugins

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect)

Description

[timeless]

patch is attached to message in url. please help get this (or a derivative) 
checked in.

Comment 1

[timeless]

attaching patch based on poor man's merge. *untested*

Comment 2

[timeless]

Attachment: changes to mozilla/modules

Comment 3

[Brian Edmond]

Attachment: In Neutrino we require the PR_LD_GROUP flag, and there are some NO_X11 defines missing for compiling

Comment 4

[Brian Edmond]

*** Bug 71179 has been marked as a duplicate of this bug. ***

Comment 5

[timeless]

um... there might be a MOZ_TOOLKIT_X11 or something define.  I should remember 
since I own the blame for whatever it is... but i'm really tired.

Comment 6

[cls]

wtc, can you review the nspr patches? Thanks.

Comment 7

[Wan-Teh Chang]

I've reviewed this patch before in bug #71179.  My comments
are reproduced below.

I will not add the PR_LD_GROUP flag to the NSPR prlink.h API.
It is not clear whether this loading option can be implemented
cross-platform.

You have two options:
1. If it is fine for PR_LoadLibraryWithFlags() to always pass
   RTLD_GROUP to dlopen(), you can modify
   mozilla/nsprpub/pr/src/linking/prlink.c as follows:

Index: prlink.c
===================================================================
RCS file: /cvsroot/mozilla/nsprpub/pr/src/linking/prlink.c,v
retrieving revision 3.34.2.9
diff -u -r3.34.2.9 prlink.c
--- prlink.c    2001/05/22 23:31:57     3.34.2.9
+++ prlink.c    2001/05/24 20:56:40
@@ -728,7 +728,11 @@
 #ifdef HAVE_DLL
     {
 #if defined(USE_DLFCN)
+#ifdef NTO
+    int dl_flags = RTLD_GROUP;
+#else
     int dl_flags = 0;
+#endif
     void *h;
 
     if (flags & PR_LD_LAZY) {

2. In mozilla/modules/plugin/nglsrc/nsPluginsDirUnix.cpp,
   call dlopen() directly, instead of PR_LoadLibraryWithFlags(),
   on Neutrino.

Comment 8

[timeless]

just do something.

Comment 9

[Peter Lubczynski]

..over to timeless because it looks like he's working on this...

Can you update the patches to the latest tip and let's get them reviewed by
module owners? Are these all the changes needed to run 4x style plugins on QNX?
Thanks!

Comment 10

[Josh Aas]

Photon is not supported any more (that I know of), and there is no NPAPI spec for it.