Closed
Bug 711972
Opened 13 years ago
Closed 13 years ago
Use a StatementCache in localStorage
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
24.92 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
There's no need to prepare all statements on startup, and simplifies shutdown management. I have this patch ready.
|
Assignee | |
Comment 1•13 years ago
|
||
The StatementCache has the advantage that it simplifies finalization, doesn't require to prepare all statements on startup and moves the statements near their use point, often clarifying the code. In future it will also allow better memory management by automatically expiring statements unused for a certain amount of time.
Attachment #583115 -
Flags: review?(honzab.moz)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 583115 [details] [diff] [review] patch v1.0 Review of attachment 583115 [details] [diff] [review]: ----------------------------------------------------------------- r=honzab Useful class :) Thanks. I trust you you have copied the statements char-by-char, I didn't check on it my self.
Attachment #583115 -
Flags: review?(honzab.moz) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/37c00830f599
Target Milestone: --- → mozilla12
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/37c00830f599
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•