711993 - Check to make sure we have a valid URI in PermissionsHelper observer

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[:Margaret Leibovic]

We're getting an error on about: pages. For Permissions:Get, we should probably just return an empty permissions array in this case, and for Permissions:Clear, we can just return.

Comment 2

[:Margaret Leibovic]

Upping to P2, since bug 716979 is a dupe.

Comment 3

[:Margaret Leibovic]

Attachment: patch

Actually, this bug is wrong as described. The only thing that will throw an exception is getting the host on an invalid URI. Also, we don't need to worry about fixing anything in the Permissions:Clear handler, because if we never got permissions in Permissions:Get because of a bad URI, clearPermission will never even get called.

The host string here is only used for display in the dialog title, so I figured we could just use the spec instead. Once bug 711774 is fixed, this won't even be an issue anymore because we'll never even end up enabling the menuitem for these bad URIs.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40993c4c18d0

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/40993c4c18d0

Comment 6

[:Margaret Leibovic]

Comment on attachment 588172 [details] [diff] [review]
patch

[Approval Request Comment]
Low-risk. This catches an exception you can run into on about: pages.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 588172 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/148296d69323