Closed
Bug 712096
Opened 13 years ago
Closed 12 years ago
Exiting 3D (Tilt) mode of the developer tools should show a transition back to a flat page
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: jaws, Assigned: vporof)
References
Details
(Whiteboard: [tilt][fixed-in-fx-team])
Attachments
(1 file, 2 obsolete files)
12.36 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Exiting 3D (Tilt) mode of the developer tools should show a transition back to a flat page. Further, it would be nice if the selected element was kept in view when transitioned back.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → vporof
Whiteboard: [tilt]
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
The selected element should indeed be kept in view when Tilt is closed. I am wondering if the transition animation back to a flat page wouldn't be annoying. (Suppose I want to instantly go back to the 3D view?).
Assignee | ||
Comment 2•12 years ago
|
||
Err.. instantly go back to the 2D view.
Assignee | ||
Comment 3•12 years ago
|
||
On the other hand, I just tested this and it would look totally awesome. We should keep this and maybe add a pref for disabling the transition if there are any issues.
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #588727 -
Flags: review?(rcampbell)
Comment 5•12 years ago
|
||
Comment on attachment 588727 [details] [diff] [review] v1 >+ this.chromeWindow.gBrowser.selectedBrowser.contentWindow.focus(); this.chromeWindow.gBrowser.selectedBrowser.focus();
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #5) > Comment on attachment 588727 [details] [diff] [review] > v1 > > >+ this.chromeWindow.gBrowser.selectedBrowser.contentWindow.focus(); > > this.chromeWindow.gBrowser.selectedBrowser.focus(); Hmm, this slipped through quite a long time ago. Thank you, fixed.
Attachment #588732 -
Flags: review?(rcampbell)
Assignee | ||
Comment 7•12 years ago
|
||
Filed and added patch in bug 718281 for hiding the animations under a pref.
Assignee | ||
Comment 8•12 years ago
|
||
Cleaned up, fixed a typo & some fails in try. https://tbpl.mozilla.org/?tree=Try&rev=99f836e9fef1
Attachment #588727 -
Attachment is obsolete: true
Attachment #588732 -
Attachment is obsolete: true
Attachment #588727 -
Flags: review?(rcampbell)
Attachment #588732 -
Flags: review?(rcampbell)
Attachment #588815 -
Flags: review?(rcampbell)
Comment 9•12 years ago
|
||
Comment on attachment 588815 [details] [diff] [review] v3 - this.presenter.tiltUI.destroy(this.presenter.tiltUI.currentWindowId); + this.presenter.tiltUI.destroy(this.presenter.tiltUI.currentWindowId, 1); , 1? or true? I think you're mixing those. Or are you just doing that to avoid a longer line? I think this'll do!
Attachment #588815 -
Flags: review?(rcampbell) → review+
Comment 10•12 years ago
|
||
Comment on attachment 588815 [details] [diff] [review] v3 and, I spoke too soon. I got this on a local build when exiting: Timestamp: 2012-01-19 17:19:55 Error: controller.arcball.reset is not a function Source File: resource:///modules/devtools/Tilt.jsm Line: 162
Attachment #588815 -
Flags: review+ → review-
Comment 12•12 years ago
|
||
Comment on attachment 588815 [details] [diff] [review] v3 changed the depencies so this applied. I am sorry I r-d you.
Attachment #588815 -
Flags: review- → review+
Assignee | ||
Comment 13•12 years ago
|
||
(In reply to Rob Campbell [:rc] (robcee) from comment #9) > Comment on attachment 588815 [details] [diff] [review] > v3 > > - this.presenter.tiltUI.destroy(this.presenter.tiltUI.currentWindowId); > + this.presenter.tiltUI.destroy(this.presenter.tiltUI.currentWindowId, > 1); > > , 1? or true? I think you're mixing those. Or are you just doing that to > avoid a longer line? > > I think this'll do! I tried avoiding a longer line. However, it bugged me too so I *did* change it to true and made the line shorter somewhere later in the patch queue.
Updated•12 years ago
|
Whiteboard: [tilt] → [tilt][land-in-fx-team]
Comment 14•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/66fcdc7716dc
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
Comment 15•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/66fcdc7716dc
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment 16•12 years ago
|
||
Comment on attachment 588815 [details] [diff] [review] v3 [Approval Request Comment] Regression caused by (bug #): New feature User impact if declined: User won't see an exit transition when closing Tilt. They may be jarred by the shock of returning to 2D viewing. Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): Very not risky! It is also fairly low down in our patchqueue and makes landing the downstream patches possible. This has been tested fairly extensively.
Attachment #588815 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
tracking-firefox11:
--- → ?
Updated•12 years ago
|
tracking-firefox11:
? → ---
Updated•12 years ago
|
Attachment #588815 -
Flags: approval-mozilla-aurora?
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•