712113 - Either brace should be clickable to add new properties in the Style panel's Rule View

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Jason Grlicky [:grlicky]]

It seems like one can only add properties by clicking on the line of the lower brace. It'd be a lot easier to be able to click on either one. Really, it would be great to be able to click on any whitespace in the style editor to add a style.

http://cl.ly/0N290t1C263g0w0p3b1D

Comment 1

[Rob Campbell [:rc] (:robcee)]

Attachment: open brace editor

Comment 2

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (robcee) from comment #1)
> Created attachment 583542 [details] [diff] [review]
> open brace editor

I think you forgot to remove your code from bug 694954 :)

Comment 3

[Joe Walker [:jwalker]]

Comment on attachment 583542 [details] [diff] [review]
open brace editor

Review of attachment 583542 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/winstripe/devtools/csshtmltree.css
@@ +231,5 @@
>    padding: 2px 5px;
>  }
>  
> +.ruleview-ruleopen {
> +  padding-right: 5px;

padding-end: 5px; ?

Comment 4

[Rob Campbell [:rc] (:robcee)]

paul: omg!

joe: oof!

double-smackdown. I feel suitably r-minused.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Attachment: open brace editor

updated patch

Comment 6

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (robcee) from comment #5)
> Created attachment 583800 [details] [diff] [review]
> open brace editor
> 
> updated patch

Does padding-end exist?
I think you meant -moz-padding-end.

Comment 7

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/378207d85641

(updated stylesheets to use -moz-padding-end)

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/378207d85641