712118 - Form autocomplete is broken because we're not receiving compositionupdate events

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[:Margaret Leibovic]

After recent IME work landed, we don't dispatch composition events, but we depend on that in FormAssistant to show autocomplete suggestions.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Alex - Can you see if we should still be firing composition events. If not, should we be firing other key events and/or input events?

Comment 2

[Alex Pakhotin (:alexp)]

We do fire the NS_TEXT_TEXT event, but there is no corresponding nsIDOM* object, so it's visible as a simple UIEvent in JS.

I've been looking at an option to fire composition events. They trigger some input handling logic, which causes unwanted side-effects with this new approach. I'll make another try, as apparently composition events are important.

Comment 3

[Alex Pakhotin (:alexp)]

Attachment: Fix

This patch fixes the issue.
I don't really like this approach - it causes NS_COMPOSITION_START and NS_COMPOSITION_END events to be sent on every character, but it works, so can be used, at least as a short-term solution.
I'll continue looking into this.

Comment 4

[Alex Pakhotin (:alexp)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5815c42a83

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5f5815c42a83

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/733f58c9368f