Closed
Bug 712188
Opened 12 years ago
Closed 12 years ago
Return correct websocket close code when browser navigates away from page.
Categories
(Core :: Networking: WebSockets, defect)
Core
Networking: WebSockets
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
742 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Right now we close with 1000 (CLOSE_NORMAL) if Cancel is called. But the IETF spec provides a code (1002: GOING_AWAY) for exactly this case. No easy way to test this automatically (we'd have to rig pywebsocket to report failure/success: doesn't seem worth the considerable effort and code fork)--I will test by hand. We could provide an error string here if we want in addition to the code, but spec says it's optional, and I don't think we need it.
Attachment #583028 -
Flags: review?(bugs)
Updated•12 years ago
|
Attachment #583028 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed6e4d7917fb
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ed6e4d7917fb
Assignee: nobody → jduell.mcbugs
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Updated•12 years ago
|
Keywords: dev-doc-needed
Comment 3•12 years ago
|
||
Noted here: https://developer.mozilla.org/en/WebSockets/WebSockets_reference/CloseEvent#Gecko_notes Also mentioned on Firefox 12 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•