Closed
Bug 712554
Opened 13 years ago
Closed 12 years ago
Remove MSVC6 support from Cairo Readme
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
VERIFIED
FIXED
mozilla13
People
(Reporter: sgautherie, Assigned: pallavikumarijha)
References
()
Details
Attachments
(1 file, 1 obsolete file)
663 bytes,
patch
|
Details | Diff | Splinter Review |
{ /gfx/cairo/README * line 15 -- VC6 is not supported. Please upgrade to VC8. } If I'm not mistaken, VC8 is (now) the lowest supported version in m-c anyway.
Flags: in-testsuite-
Comment 1•12 years ago
|
||
I don't understand this bug. README says VC6 is not supported which is true. Do you just want the reference removed?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #1) > Do you just want the reference removed? Yes, I think this sentence doesn't have much value now.
Attachment #604005 -
Flags: review?(sgautherie.bz)
Reporter | ||
Updated•12 years ago
|
Attachment #604005 -
Flags: review?(sgautherie.bz) → review?(jmuizelaar)
Updated•12 years ago
|
Attachment #604005 -
Flags: review?(jmuizelaar) → review+
Reporter | ||
Comment 4•12 years ago
|
||
Please attach a patch according to https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Assignee: nobody → pallavikumarijha
Status: NEW → ASSIGNED
Attachment #604005 -
Attachment is obsolete: true
(In reply to Serge Gautherie (:sgautherie) from comment #4) > Please attach a patch according to > https://developer.mozilla.org/en/ > Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check- > in_for_me.3F I made the patch according to the described formate,but while attaching it there was no option for requestee so its coming without flag is it fine?
Reporter | ||
Comment 7•12 years ago
|
||
(In reply to pallavi from comment #6) > I made the patch according to the described formate,but while attaching it No, it still misses author and description. > there was no option for requestee so its coming without flag is it fine? See https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch#Committing_the_patch
Comment 8•12 years ago
|
||
I tried to guess the field from your email, I hope I got it right. Congrats on your first check-in, it should be in the main branch within a 24 hours: https://hg.mozilla.org/integration/mozilla-inbound/rev/5bb28e575749
thank you :),but according to comment 7 it was missing some criteria right?
Comment 10•12 years ago
|
||
It was just referring to a description and author field for the commit. The only way I know how to do this is mercurial queues but no need to use it until you start building more complex changesets. https://developer.mozilla.org/en/Mercurial_Queues
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5bb28e575749
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → mozilla13
Reporter | ||
Comment 12•12 years ago
|
||
V.Fixed, per MXR search. (In reply to Benoit Girard (:BenWa) from comment #10) > It was just referring to a description and author field for the commit. The > only way I know how to do this is mercurial queues but no need to use it > until you start building more complex changesets. Ftr, mq is quite easy to use. And patches can always be manually edited.
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug]
You need to log in
before you can comment on or make changes to this bug.
Description
•