712624 - Permanent orange: TEST-UNEXPECTED-FAIL | test-autohide-menubar.js | test_autohidden_menubar_3pane, test_autohidden_menubar_message_window, test_autohidden_menubar_compose_window, test_autohidden_menubar_address_book

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

This test failure is a direct result of Tabs on Top landing, and is due to the fact that I changed the name of an attribute without updating a test.  Fix forthcoming.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

So I failed to fix up this test once I removed the toolbarindex attribute from the menuitems.

Instead of adding the rather fragile index, I now attach the toolbar`s ID to the menuitem, and query for that in the test.

Comment 2

[Rain [:rain1] (inactive)]

Comment on attachment 583493 [details] [diff] [review]
Patch v1

yep, I think this makes sense. r+ assuming this makes tests pass.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 583493 [details] [diff] [review]
Patch v1

The tests do indeed pass for me.  Requesting approval for landing on Aurora.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3118433d5808

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/ae083d2568ed