Closed Bug 712887 Opened 13 years ago Closed 13 years ago

Style Editor should always show the Save button on the currently edited style sheet

Categories

(DevTools :: Style Editor, defect)

Product:
DevTools
Component:
Style Editor
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(firefox11 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- verified

People

(Reporter: cedricv, Unassigned)

Details

(Whiteboard: [qa+][qa!:11])

Attachments

(1 file)

patch
1.49 KB, patch
paul
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Imho an unseen regression brought with the new skin.

The selected style sheet should have the Save action visible at all times for discoverability's sake - currently you have no visible way to know how to save (only Ctrl-S)
Attached patch patch — — Splinter Review 

        Attachment #583740 -
        Flags: review?(paul)

    
  

        Attachment #583740 -
        Flags: review?(paul) → review+

    
  
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 583740 [details] [diff] [review]
patch

I believe this might be a good candidate for Aurora.
This is a minimal change that fixes an UI regression introduced with the new skin in bug 687702 (which landed shortly before branching)

        Attachment #583740 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 583740 [details] [diff] [review]
patch

[Triage Comment]
Please re-nominate once this has landed on m-c and had at least a couple of days to bake.

        Attachment #583740 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5bbf02ceb383
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12

    
    

    
  
Comment on attachment 583740 [details] [diff] [review]
patch

Re-noming as requested, this landed the 29th.

        Attachment #583740 -
        Flags: approval-mozilla-aurora- → approval-mozilla-aurora?

    
    

    
  
Comment on attachment 583740 [details] [diff] [review]
patch

[Triage Comment]
Thanks! Approved for Aurora.

        Attachment #583740 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Verified on Build identifier: Mozilla/5.0 (X11; Linux i686; rv:12.0a1) Gecko/20120125 Firefox/12.0a1

    
  
Whiteboard: [qa+]

    
    

    
  
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0

Verified that "Save" button is always shown on the currently edited style sheet using Firefox 11 beta 1 on Win 7, Ubuntu 11.10 and Mac OS X 10.6.

          status-firefox11:
          fixed → verified
Whiteboard: [qa+] → [qa+][qa!:11]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: