Closed
Bug 713091
Opened 13 years ago
Closed 13 years ago
Clicking on "Close Video" doesn't stop video
Categories
(addons.mozilla.org Graveyard :: Discovery Pane, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
6.3.6
People
(Reporter: bobby, Assigned: gkoberger)
Details
Steps: 1. Visit https://services.addons.mozilla.org/en-US/firefox/discovery/pane/pane/pane/strict 2. Click on "Learn More" 3. Click on either of the "Close Video" buttons. 4. Repeat steps 2-4 as desired until trippiness effect is accomplished. The video never stops playing, so you can click on that "Learn More" button a few times in a row to have the video playing on top of itself. This creates several Popcorn instances too. Perhaps try using the `destroy` method on Popcorn objects.
Assignee | ||
Comment 1•13 years ago
|
||
Whoops :) I'm going to hijack this bug to add this: - On close, we should reset the right sidebar and all elements on the page. Otherwise, it can get stuck in a weird state if you close while something is happening.
Assignee: nobody → gkoberger
Comment 2•13 years ago
|
||
(In reply to Bobby Richter [:bobby] from comment #0) > This creates several Popcorn instances too. Perhaps try using the `destroy` > method on Popcorn objects. Thanks for filing! Also, FWIW, I know `destroy` is in the popcorn-1.0.js source, but I can't find it documented here: http://popcornjs.org/popcorn-docs/media-methods/
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Chris Van Wiemeersch [:cvan] from comment #2) > Thanks for filing! Also, FWIW, I know `destroy` is in the popcorn-1.0.js > source, but I can't find it documented here: > http://popcornjs.org/popcorn-docs/media-methods/ I'm not really clear on why. I'll ask. Thanks :).
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → 6.3.6
Assignee | ||
Comment 4•13 years ago
|
||
I refactored all the code. Fixes the original problem by only ever having one Popcorn object on the page (and hiding and showing rather than destroying and recreating). https://github.com/mozilla/zamboni/commit/e0200f2 Also fixes the problems I mentioned by triggering a "close" on everything when the video is closed, which should reset the page.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 5•13 years ago
|
||
this seems fixed now. verified at https://services.addons.mozilla.org/en-US/firefox/discovery/pane/pane/pane/strict
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•